Fact-checked by Grok 2 weeks ago

When You're Smiling

"When You're Smiling (The Whole World Smiles with You)" is a composed by and Larry Shay (music) with by Joe Goodwin, first published in 1928. The song's cheerful advocate maintaining a positive attitude, stating that "when you're smilin', the whole world smiles with you," while "when you're cryin', you bring on the rain," emphasizing the contagious nature of emotions. Its first recording was by Henry Thies and His Sinton Orchestra, featuring vocal by Dewey, on May 28, 1928. The tune quickly became a hit, with early popular versions by Seger Ellis in 1928 and in 1929, the latter's recording establishing it as an enduring standard in jazz repertoire. Over the decades, it has been covered more than 475 times by renowned artists, including (1938), (multiple times, notably in the 1952 film Meet Danny Wilson), , , and big bands led by Count Basie, , and , as well as instrumental interpretations by the Dave Brubeck Quartet and . Armstrong's versions, recorded in 1929, 1932, and 1956, are particularly iconic, with the 1932 take featured in the 1984 film . Culturally, "When You're Smiling" has permeated American popular music and media, symbolizing optimism and resilience, especially during the Great Depression era when it encouraged listeners to find joy amid hardship. Its upbeat melody and simple, uplifting message have made it a staple in films, television, and commercials, including a cover by Lady Gaga and Joaquin Phoenix in the 2024 film Joker: Folie à Deux, reinforcing its status as an all-American anthem of positivity. The song bears some resemblance to the earlier Spanish canción "Amapola," but its distinct charm lies in its straightforward celebration of human connection through smiles.

Background and Composition

Origins and Publication

"When You're Smiling (The Whole World Smiles with You)" is a popular song credited to the songwriting team of and Larry Shay for the music and Joe Goodwin for the lyrics. The composition emerged from the collaborative environment of , City's hub for publishing during the era. The song was first published in 1928 by Mills Music Inc. in , with released that year capturing the upbeat spirit of the period. This timing placed it amid , a decade characterized by economic prosperity, cultural exuberance, and the flourishing of jazz-influenced popular tunes in American music. The release occurred just prior to the Wall Street Crash of October 1929, reflecting the pre-Depression optimism that permeated Tin Pan Alley's output of lighthearted standards. Seger Ellis's 1928 recording marked the song's initial commercial success, introducing it to audiences shortly after publication.

Lyrics and Musical Structure

The lyrics of "When You're Smiling" center on themes of cheerful optimism and the contagious nature of happiness, portraying smiling as a transformative act that influences the surrounding world positively. The declares, "When you're smiling, when you're smiling / The whole world smiles with you," highlighting how personal positivity radiates outward to uplift others. This message is extended in the verse, which contrasts emotional states by noting, "But when you're crying, you bring on the rain / So stop your sighing, start your smiling," urging a shift from sorrow to joy to invite metaphorical sunshine. Musically, the song adheres to the classic AABA form prevalent in popular standards, structured as a 32-bar in 4/4 time, which provides a balanced framework for repetition and variation. The two A sections introduce and reiterate the primary melody, the B section offers harmonic contrast, and the final A resolves the progression, creating a sense of completion typical of the era's songs. Often notated in Bb major for instrumental accessibility, though sometimes transposed to , this form supports straightforward while allowing room for elaboration. The features a bright, ascending -key line that reinforces the uplifting lyrical intent, complemented by syncopated rhythms in the phrasing that inject energy and facilitate . These rhythmic displacements, common in the song's upbeat moderato , emphasize off-beats to create a swinging feel, particularly in the where repetitive motifs encourage vocal or embellishments. The simple foundation, relying on basic and dominant chords, prioritizes melodic clarity over complexity, making it adaptable for play.

Early Recordings and Rise to Popularity

Initial Commercial Releases

The first recording of "When You're Smiling" was by Henry Thies and His Hotel Sinton Orchestra, featuring vocal refrain by Don Dewey, on May 28, 1928. The first major commercial recording was by pianist and vocalist , captured on June 26, 1928, in and released that year on ' 78 RPM disc (catalog number 1494-D), paired with "When You Said 'Good-Night' (Did You Really Mean 'Good Bye?')". delivered the track in an intimate piano-vocal style, emphasizing the song's upbeat melody and optimistic lyrics, which resonated with audiences during the late . This version climbed to number 4 on the U.S. charts, establishing it as the tune's inaugural hit and introducing its cheerful waltz rhythm to a broad listening public. By 1930, the song gained further traction through Ted Wallace and His Campus Boys' recording for (catalog number 2104-D), released on January 18, 1930. The ensemble's energetic brass and rhythm section amplified the track's infectious appeal, helping its presence in youth-oriented settings. This release built on the song's growing radio exposure, where its simple, singable structure encouraged amateur performances and purchases. The initial commercial releases drove the song's early popularity through a mix of , distribution, and radio broadcasts, amid the Jazz Age's expanding access to home entertainment. With ownership surging—annual U.S. sales of phonographs and records reached $106 million in 1921—these versions facilitated the shift from stages to affordable recorded formats, making "When You're Smiling" a staple in living rooms and social gatherings. Armstrong's 1929 Okeh recording would soon amplify this momentum.

Louis Armstrong's Influential Version

Louis Armstrong recorded "When You're Smiling" on September 11, 1929, in with his Orchestra for , releasing it as the A-side of the 78 rpm single Okeh 41298, backed by "." The session produced both vocal and takes, with the vocal version featuring Armstrong's warm, gravelly singing of the lyrics alongside a prominent solo by Armstrong himself, showcasing his signature melodic . Armstrong's interpretation marked a pivotal in vocal performance, infusing the pop tune with improvisational phrasing and an exuberant, emotionally resonant delivery that prioritized warmth and rhythmic over rigid adherence to the . His gravelly and playful vocal inflections transformed the song's simple optimism into a vehicle for personal expression, establishing it as a and influencing subsequent singers in emphasizing individuality and joy in phrasing. This approach built briefly on Seger Ellis's 1928 hit recording as an early template for adapting the tune to sensibilities. The 1929 recording's impact was profound, defining the song's scat-era jazz sound through its blend of vocal charm and instrumental flair, and Armstrong revisited it in subsequent sessions, including a 1932 Columbia version and a 1956 take for Verve's Louis Armstrong Musical Autobiography project. Released amid the onset of the Great Depression, it was praised for its uplifting spirit, serving as an encouraging anthem that resonated with audiences seeking positivity during economic hardship. Armstrong's techniques here further shaped vocal jazz, inspiring improvisational freedom in artists like Billie Holiday and Ella Fitzgerald by demonstrating how voice could mirror trumpet-like expressiveness.

Notable Later Recordings

Jazz and Swing Interpretations

Billie Holiday's 1938 recording of "When You're Smiling," accompanied by the Orchestra, exemplifies her signature phrasing, infusing the optimistic standard with subtle emotional nuance and a swinging featuring on . This version, captured on in , highlights Holiday's ability to personalize pop tunes through intimate vocal delivery amid the ensemble's light, propulsive backing. Benny Goodman's swing arrangements of the song in transformed it into a vehicle for high-energy performances, with his often taking prominent leads in call-and-response patterns. The Orchestra's interpretations, beginning with a 1930 session featuring vocalist (credited as Sunny Smith), evolved in the to emphasize sophisticated brass voicings and intricate ensemble interplay, allowing sections to weave contrapuntal lines around the melody. These takes, including live performances into the 1940s, showcased Ellington's compositional approach to standards, adapting the tune's form for collective improvisation in settings. During the , "When You're Smiling" flourished in ballrooms and dance halls, where its AABA structure provided an ideal framework for extended solos by instrumentalists, inspiring dozens of versions that built on Louis Armstrong's 1929 recording as a foundational blueprint for scat-infused, upbeat renditions.

Pop, Country, and Modern Covers

recorded a swinging big-band arrangement of "When You're Smiling" on April 24, 1950, for , which became a staple in his live performances and albums like Sing and Dance with Frank Sinatra. The track featured an upbeat, orchestral style that highlighted Sinatra's charismatic vocal delivery, contributing to its enduring popularity in his catalog. Dean Martin offered a more laid-back, lounge-oriented interpretation in a 1951 Capitol Records session conducted by Dick Stabile, released as part of his early 1950s output including the compilation Dean Martin: The Capitol Recordings, Vol. 3 (1951-1952). Martin's version emphasized smooth phrasing and a relaxed charm, aligning with his signature Rat Pack-era persona and appealing to pop audiences seeking easy-listening fare. In the genre, fiddler Cliff Bruner and his Wanderers adapted the song into a style on in 1938, with the single peaking at No. 15 on the charts in and marking one of the earliest crossovers from pop to rural audiences. The recording incorporated and , transforming the tune into a lively number that resonated in honky-tonk settings. Modern revivals include Michael Bublé's jazz-inflected pop rendition on his 2018 album , produced with , which blended contemporary production with nostalgic swing elements to appeal to new listeners. The song has also appeared in long-running advertising campaigns, such as Labatt Blue's "When You're Smiling" effort launched in 1968, which used upbeat versions to evoke feel-good, communal branding in commercials depicting outdoor leisure activities.

Cultural Impact and Legacy

Use in Film, Media, and Advertising

The song "When You're Smiling" has been prominently featured in numerous , often underscoring themes of joy or irony through its upbeat melody. Louis Armstrong's 1932 recording appears in the 1984 film The Cotton Club, directed by , where it evokes the era's scene. In the 1950 musical When You're Smiling, starring , the is performed by Laine himself, serving as a central narrative element in this biopic-inspired story of a bandleader's rise. Frank Sinatra sings the song in the 1952 drama Meet Danny Wilson, integrating it into scenes of aspiring musicians navigating . Later cinematic uses include Louis Prima's version in the 1999 comedy , playing during a mob summit for comedic contrast, and in the 2003 film Anger Management, where it highlights therapeutic breakthroughs. On television, the song has appeared in variety shows and specials, leveraging its feel-good vibe for live performances. performed it on The Frank Sinatra Show (also known as the Bulova Watch Show) in 1951, delivering a swinging rendition that showcased his emerging television presence. and sang a medley including "When You're Smiling" on The Ed Sullivan Show in 1959, blending it with "Oh Marie" in a high-energy set. The 1973 CBS special Ann-Margret: When You're Smiling featured the entertainer performing the standard alongside guests like and , emphasizing its timeless appeal in musical revues. In advertising, "When You're Smiling" has been licensed for campaigns promoting positivity and well-being, often tying into its lyrical motif of shared happiness. Apple used Armstrong's version in its 2010 iPhone 4 commercials to highlight video calling features. brands have adopted it for uplifting messages, such as AdventHealth's 2025 TV spots featuring Prima's recording to convey recovery and wholeness, and ClearChoice Dental's 2012 campaign pairing it with implant success stories. IHOP incorporated Armstrong's take in 2022 ads showing friends enjoying breakfast, while NewYork-Presbyterian Hospital's 2013 spot used it to illustrate patient smiles post-treatment. Grocery and food brands like (2013 UK ads) and McCain (2017 smiles campaign) employed covers to evoke family joy. During the Great Depression, "When You're Smiling" emerged as an unofficial anthem for morale-boosting radio broadcasts, its optimistic lyrics providing uplift amid economic hardship. Released in 1928 and popularized by Seger Ellis's early recording, it was programmed on network shows like CBS's Gillette Original Community Sing (1936–1937), where audiences participated in sing-alongs of the tune alongside other cheerful standards to foster communal resilience. Louis Armstrong's 1929 and 1932 versions further amplified its role in live radio airings, helping it become a staple for cheering the public through the era's challenges.

Adoption in Sports and Public Life

The song "When You're Smiling" holds a prominent place in the traditions of , where it serves as the official club anthem. Adopted by supporters in the 1990s, it is sung collectively by fans during matches to foster unity and encouragement, reflecting the song's uplifting message of communal positivity. A modern rendition by local artist Jersey Budd is played over the stadium speakers just before kick-off at home games in the , enhancing the pre-match atmosphere. The anthem gained global attention during Leicester City's improbable 2015–2016 title-winning season, often dubbed the "Foxes' fairy tale." As the club defied 5000–1 odds to claim the championship, fans' passionate renditions of "When You're Smiling" at matches and public celebrations symbolized resilience and joy, with supporter-recorded versions circulating widely online and in media coverage. This adoption underscores the song's role in sports as a participatory that amplifies collective spirit beyond mere entertainment.

References

  1. [1]
    Jazz Standards Songs and Instrumentals (When You're Smiling)
    Armstrong first recorded it in 1929 and then again in 1932 and 1956. His is ... “When You're Smiling” has been recorded by vocalist Eddie Jefferson ...
  2. [2]
    None
    - **Writers**: Not specified in the content.
  3. [3]
    Louis Armstrong's 'When You're Smiling' - National Review
    Aug 22, 2019 · It is the all-American song. The lyrics are a cheer-up sentiment, straight from a drugstore card rack. Smile, and the whole world smiles with you.
  4. [4]
    When You're Smiling - The Early Versions
    Nov 3, 2009 · "When You're Smiling" was written in 1928 by the team of Mark Fisher, Larry Shay and Joe Goodwin. All three men were professional songwriters and frequent ...
  5. [5]
    When you're smiling (the whole world smiles with you). - YorkSpace
    Sheet Music Collections. When you're smiling (the whole world smiles with you). ... Publisher. New York : Mills Music Inc., 1928. plumx widget. Abstract ...
  6. [6]
    Tin Pan Alley: Where America's Recording Industry Was Born
    Apr 22, 2022 · In the late 19th and early 20th centuries, recorded music existed, first on carnauba wax-coated tubes, then on fragile lacquer disks, but ...Missing: Twenties | Show results with:Twenties
  7. [7]
    When You're Smiling (The Whole World Smiles With You) Lyrics
    “When You're Smiling” is a song by Larry Shay, Mark Fisher, and Joe Goodwin, and made famous by Louis Armstrong, who recorded it at least three times.
  8. [8]
    When You're Smiling Lyrics by Dean Martin - Street Directory
    (Mark Fisher - Joe Goodwin - Larry Shay) When you're smiling. When you're smiling. The whole world smiles with you. When you're laughing
  9. [9]
    What do you mean by “Songbook standard”? - WordPress.com
    Nov 10, 2021 · From the Jazz Era to the early 1950's, the 32-bar form or AABA form was prevalent in the classic American popular song. ... When You're Smiling.
  10. [10]
    Commercial Bridge - Angelfire
    The type of substitution employed is shown in brackets below the song title. When You're Smiling (Standard - 1928) ... structure following the AABA song form.
  11. [11]
  12. [12]
    The Double Sixteen-Bar Form - Jazz Guitar Online
    Jun 28, 2014 · I began to see that many, many songs--"All of Me," "Wine and Roses," "When You're Smiling," etc etc, had long opening sections which then nearly ...
  13. [13]
  14. [14]
  15. [15]
  16. [16]
    When You're Smiling (The Whole World Smiles with You)
    When You're Smiling (The Whole World Smiles with You) · First recording by Henry Thies and His Hotel Sinton Orchestra - Vocal Refrain by Don Dewey (May 28, 1928).
  17. [17]
    [PDF] Thomas Edison and the Entertainment Phonograph
    Between 1880 and 1910 the phonograph became a mass-marketed consumer product. During the late 1870s Thomas Edison's tinfoil phonograph was a curiosity.
  18. [18]
  19. [19]
    OKEH 78rpm numerical listing discography: 41000 - 41499
    Apr 3, 2016 · LOUIS ARMSTRONG & HIS ORCH, SOME OF THESE DAYS, 402943=A, VO3202, -, 9/10/29, SHELTON BROOKS. 41298, LOUIS ARMSTRONG & HIS ORCH, WHEN YOU'RE ...
  20. [20]
    Louis Armstrong - 20 Best Jazz Songs. Expert insights & audio clips
    Apr 28, 2021 · In the middle of the record, we hear Armstrong's distinct voice for the first time in a stunning display of scat singing. The Louis Armstrong ...
  21. [21]
    When You're Smiling - The Phono Project
    Apr 2, 2018 · With its slow tempo and joyful lyrics this song encouraged the people to keep on smiling. When this song was first written in 1928 the world ...
  22. [22]
    When You're Smiling - The Later Versions
    Nov 9, 2009 · Armstrong's final attempt at "When You're Smiling" came on December 12, 1956. It was recorded for the ambitious Musical Autobiography project ...
  23. [23]
    The Enduring Legacy of Louis Armstrong | SDPB
    Aug 5, 2021 · Armstrong created a loose, free, informal, virile and swinging vocal style that influenced Billie Holiday, Ella Fitzgerald, Frank Sinatra and ...<|control11|><|separator|>
  24. [24]
  25. [25]
    Lester Young & Billie Holiday - Insightful analysis by Scott Yanow
    Apr 20, 2021 · “When You're Smiling” January 6, 1938. Buck Clayton (tp), Benny Morton (tb), Lester Young (ts), Teddy Wilson (p), Freddie Green (g), Walter ...Missing: covers | Show results with:covers
  26. [26]
    When You're Smiling - Eng 6 Jan 1938 New York - Spotify
    Listen to When You're Smiling - Eng 6 Jan 1938 New York on Spotify. Song · Billie Holiday · 2002.Missing: covers | Show results with:covers
  27. [27]
    Discography - Benny Goodman
    When You're Smiling (The Whole World Smiles With You). Benny Goodman Trio. 02 ... From Spirituals to Swing: Complete Legendary 1938-1939 Carnegie Hall Concerts.
  28. [28]
    Artist: Benny Goodman | SecondHandSongs
    When You're Smiling · Benny Goodman Trio, September 1952, Henry Thies and His ... Benny Goodman Carnegie Hall Jazz Concert · Benny Goodman and His Orchestra ...
  29. [29]
    1930 — 1939 | Ellingtonia.com - A Duke Ellington Discography
    When You're Smiling - vIM, CBS 68275, Cl(F) 586, MoJ MJCD-123, Pe 15272 ... DUKE ELLINGTON AND HIS ORCHESTRA, Stockholm, Sweden, 29 April 1939. Concert at ...
  30. [30]
  31. [31]
    April 24, 1950 | Sinatraology - The Ultimate Frank Sinatra Discography
    When You're Smiling (The Whole World Smiles with You) - April 24, 1950 ... Columbia Records. Location, New York City. Session #2 - Vocal overdub. Date, 1950.
  32. [32]
    Frank Sinatra "When You're Smiling" - YouTube
    Feb 10, 2018 · "When You're Smiling" written by Larry Shay, Mark Fisher and Joe Goodwin in 1928 was recorded by Frank Sinatra on April 24, 1950 for Swing ...<|separator|>
  33. [33]
  34. [34]
    MARTIN, Dean: When You're Smiling (1946-1953) - Naxos Records
    Release Date: 05/2004. About This Recording. MARTIN, Dean: When You're Smiling (1946-1953). More. Tracklist. Artist details. Berlin, Irving Berlin, Irving ...
  35. [35]
    Clif Bruner (by Dick Grant) - Praguefrank's Country Discography
    Jun 14, 2016 · 64510-A WHEN YOU'RE SMILING (THE WHOLE WORLD SMILES WITH YOU)-1-5 5660 A, 46096 B, String STR-801. (Mark Fisher-Joe Goodwin-Larry Shay) Rhino ...
  36. [36]
    Cliff Bruner | mogc - Museum of the Gulf Coast
    Aug 25, 2000 · Other hits in 1939-1942 included "Sorry," "Kelly Swing," "I'll Keep On Loving You," and "When You're Smiling." Bruner continued to perform into ...
  37. [37]
    Michael Bublé - When You're Smiling [Official Audio] - YouTube
    Nov 17, 2018 · ... album ❤️ available now: http ... Michael Bublé - When You're Smiling [Official Audio]. 1.9M views · 6 ...
  38. [38]
    50 years of Labatt Blue: Timeline - Strategy Online
    Oct 1, 2006 · Labatt continues with the 'When You're Smiling' campaign, with different spots showing young folks tobogganing, floating down a river on ...
  39. [39]
    When You're Smiling (1950) - Soundtracks - IMDb
    When You're Smiling. Written by Mark Fisher, Joe Goodwin, and Larry Shay. Sung by Frankie Laine ; Georgia On My Mind. Written by Hoagy Carmichael and Stuart ...
  40. [40]
    Analyze This (1999) - Soundtracks - IMDb
    When You're Smiling (The Whole World Smiles With You). Written by Mark Fisher, Joe Goodwin, Larry Shay, Harry B. · The Sheik of Araby. Written by Mark Fisher, ...<|control11|><|separator|>
  41. [41]
    Anger Management (2003) - Soundtracks - IMDb
    When You're Smiling (The Whole World Smiles with You). Written by Mark Fisher, Joe Goodwin and Larry Shay. Published by EMI Mills Music Inc. and Music by Shay ...
  42. [42]
    Sinatra on TV | Guitars101 - Guitar Forums
    Oct 1, 2023 · Look At Me Now". Sinatra on TV collection (link) ... 55) When You're Smiling [1951-05-05] (link) 56) My Romance [1951-05-05] (link) 57 ...
  43. [43]
    When You're Smiling/Oh Marie (Medley/Live On The Ed Sullivan ...
    Dec 7, 2023 · When You're Smiling/Oh Marie (Medley/Live On The Ed Sullivan Show ... Keely Smith on the Frank Sinatra show 1958. soapbxprod•270K views.
  44. [44]
    Ann-Margret: When You're Smiling (TV Special 1973) - IMDb
    Rating 8.9/10 (10) Ann-Margret: When You're Smiling: Directed by Art Fisher. With Ann-Margret, George Burns, The Firm of Hodges James and Smith, Bob Hope.Missing: sitcoms | Show results with:sitcoms
  45. [45]
    Songs in TV Commercials 2010 - splendAd
    When You're Smiling (The Whole World Smiles With You). Apple - iPod nano ... Coca Cola - Sleepwalker, Maurice Ravel, Bolero. Coffee-mate - Express Yourself ...
  46. [46]
    Advent Health TV Spot, 'When You're Smiling' Song by Louis Prima
    Jan 21, 2025 · Check out Advent Health's 60 second TV commercial, 'When You're Smiling' from the Hospitals & Clinics industry.
  47. [47]
    ClearChoice TV Spot, 'When You Smile' - iSpot
    Aug 22, 2012 · “America's #1 Choice for Dental Implants”. Songs: When You're Smiling - Louis Armstrong. Phone: 888-588-4554. Ad URL: http://www.clearchoice.com.<|separator|>
  48. [48]
    IHOP TV Spot, 'Pick Your Plate' Song by Louis Armstrong - iSpot
    Aug 23, 2022 · With "When You're Smiling" by Louis Armstrong playing in the background, you view the process of food being made for a group of friends at IHOP.
  49. [49]
    New York Presbyterian Hospital: Danion Jones - YouTube
    Apr 8, 2013 · ... When You're Smiling" in powerful new ad for New York-Presbyterian Hospital. Credits: Advertising Agency: Munn Rabot Client: New York ...
  50. [50]
    When You're Smiling (From "Waitrose" Advert) - Spotify
    Listen to When You're Smiling (From "Waitrose" Advert) on Spotify. Song · Lester Young, Billie Holiday · 2013.
  51. [51]
    McCain Smiles 'When You're Smiling' Commercial - YouTube
    Nov 24, 2017 · When You're Smiling/The Sheik Of Araby (Remastered). Louis Prima ... snl commercials that made me spit take 2. idjit•5M views · 14:32 · Go to ...Missing: 2000s | Show results with:2000s
  52. [52]
    The Stories Behind 7 Famous Songs about Smiling - Mental Floss
    Oct 5, 2018 · Here are the stories behind seven smiley songs, from upbeat crooners to cheesy power ballads. 1. "SARA SMILE" // HALL & OATES
  53. [53]
    [PDF] MEDIATED COMMUNITY AND PARTICIPATORY BLACKFACE IN ...
    Other favoured selec- tions were 'Pack Up Your Troubles in Your Old Kit Bag and Smile, Smile, Smile' (1915),. 'When You're Smiling' (1928), and 'Happy Days ...<|control11|><|separator|>
  54. [54]
    Fans Chants - Origins - Leicester Till I Die
    Try watching this video on www.youtube.com, or enable JavaScript if it is disabled in your browser. When You're Smiling Yes, we know. This is the actual ...
  55. [55]
    Leicester City Songs and Chants: From When You're Smiling to ...
    Oct 21, 2025 · When You're Smiling. It would be untrue to suggest that Leicester City fans are the only group of supporters who sing When You're Smiling, given ...Missing: origin | Show results with:origin
  56. [56]
    The impossible has become possible at Leicester because of Khun ...
    Oct 20, 2019 · “When you're smiling, the whole world smiles with you.” It is a fitting anthem for Leicester City, a song about keeping a brave face in ...